Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/WebKit/chromium/WebKit.gyp

Issue 16881011: Remove WEBKIT_DLL and replace it with COMPONENT_BUILD (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: updates Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/WebKit/chromium/WebKitUnitTests.gyp » ('j') | Source/WebKit/chromium/WebKitUnitTests.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebKit/chromium/WebKit.gyp
diff --git a/Source/WebKit/chromium/WebKit.gyp b/Source/WebKit/chromium/WebKit.gyp
index 3301627a209fe113bff8510ef616d7b85b5be91d..c35c73b9aa204496cee82f9efdc628dcc75708c8 100644
--- a/Source/WebKit/chromium/WebKit.gyp
+++ b/Source/WebKit/chromium/WebKit.gyp
@@ -556,9 +556,6 @@
],
'conditions': [
['component=="shared_library"', {
- 'defines': [
- 'WEBKIT_DLL',
- ],
'dependencies': [
'../../core/core.gyp:webcore_derived',
'../../core/core.gyp:webcore_test_support',
@@ -577,11 +574,6 @@
'<(DEPTH)/v8/tools/gyp/v8.gyp:v8',
# We must not add webkit_support here because of cyclic dependency.
],
- 'direct_dependent_settings': {
- 'defines': [
- 'WEBKIT_DLL',
- ],
- },
'export_dependent_settings': [
'<(DEPTH)/url/url.gyp:url_lib',
'<(DEPTH)/v8/tools/gyp/v8.gyp:v8',
« no previous file with comments | « no previous file | Source/WebKit/chromium/WebKitUnitTests.gyp » ('j') | Source/WebKit/chromium/WebKitUnitTests.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698