Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1688043004:
[docs] Document MemoryInfra startup tracing on Android (Closed)
|
Created:
4 years, 10 months ago by petrcermak Modified:
4 years, 10 months ago CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[docs] Document MemoryInfra startup tracing on Android
Follow-up for: https://codereview.chromium.org/1601523007
TBR=simonhatch@chromium.org
Committed: https://crrev.com/090678c8ee6fdce2923ee535da5aadc5890ffbe6
Cr-Commit-Position: refs/heads/master@{#374890}
Patch Set 1 #
Total comments: 11
Patch Set 2 : Address Primiano's comments #
Total comments: 1
Messages
Total messages: 16 (9 generated)
Description was changed from ========== [docs] Document MemoryInfra infra startup tracing on Android ========== to ========== [docs] Document MemoryInfra infra startup tracing on Android Follow-up for: https://codereview.chromium.org/1601523007 ==========
petrcermak@chromium.org changed reviewers: + primiano@chromium.org
Hi, please review this small documentation patch. Thanks, Petr
Description was changed from ========== [docs] Document MemoryInfra infra startup tracing on Android Follow-up for: https://codereview.chromium.org/1601523007 ========== to ========== [docs] Document MemoryInfra startup tracing on Android Follow-up for: https://codereview.chromium.org/1601523007 ==========
many thanks. just few notes, LGTM once addressed https://codereview.chromium.org/1688043004/diff/1/components/tracing/docs/mem... File components/tracing/docs/memory_infra_startup_tracing.md (right): https://codereview.chromium.org/1688043004/diff/1/components/tracing/docs/mem... components/tracing/docs/memory_infra_startup_tracing.md:17: --no-sandbox \ no need of --no-sandbox on Android. Let's keep the one above for a bit, until it makes to stable. IIRC on Android we never really needed no-sanbox, was a linux thing only. https://codereview.chromium.org/1688043004/diff/1/components/tracing/docs/mem... components/tracing/docs/memory_infra_startup_tracing.md:23: $ clank/bin/adb_run_chrome # Googlers only. hmm remove this, I imagine internal folks know how do run chrome. Also because otherwise you need a copy also of the command line command above https://codereview.chromium.org/1688043004/diff/1/components/tracing/docs/mem... components/tracing/docs/memory_infra_startup_tracing.md:25: $ adb pull /storage/emulated/legacy/Download/trace.json # After tracing. I think that this should be aliased also via /sdcard/Download/trace.json, which is easier to type and remember https://codereview.chromium.org/1688043004/diff/1/components/tracing/docs/mem... components/tracing/docs/memory_infra_startup_tracing.md:58: $ build/android/adb_chrome_public_command_line --no-sandbox no need of --no-sandbox https://codereview.chromium.org/1688043004/diff/1/components/tracing/docs/mem... components/tracing/docs/memory_infra_startup_tracing.md:61: $ clank/bin/adb_run_chrome # Googlers only. ditto https://codereview.chromium.org/1688043004/diff/1/components/tracing/docs/mem... components/tracing/docs/memory_infra_startup_tracing.md:66: Android (e.g. "/storage/emulated/legacy/Download/trace.json"). Note that startup /sdcard
petrcermak@chromium.org changed reviewers: + simonhatch@chromium.org
primiano@: Thanks for your comments. Could you please have another quick look (I added an extra note to the first section)? simonhatch@: Could I please get an owner stamp? Thanks, Petr https://codereview.chromium.org/1688043004/diff/1/components/tracing/docs/mem... File components/tracing/docs/memory_infra_startup_tracing.md (right): https://codereview.chromium.org/1688043004/diff/1/components/tracing/docs/mem... components/tracing/docs/memory_infra_startup_tracing.md:17: --no-sandbox \ On 2016/02/11 12:04:55, Primiano Tucci wrote: > no need of --no-sandbox on Android. > Let's keep the one above for a bit, until it makes to stable. IIRC on Android we > never really needed no-sanbox, was a linux thing only. Done. https://codereview.chromium.org/1688043004/diff/1/components/tracing/docs/mem... components/tracing/docs/memory_infra_startup_tracing.md:25: $ adb pull /storage/emulated/legacy/Download/trace.json # After tracing. On 2016/02/11 12:04:55, Primiano Tucci wrote: > I think that this should be aliased also via /sdcard/Download/trace.json, which > is easier to type and remember Done (I wanted to mirror https://www.chromium.org/developers/how-tos/trace-event-profiling-tool/record..., which mentions both). https://codereview.chromium.org/1688043004/diff/1/components/tracing/docs/mem... components/tracing/docs/memory_infra_startup_tracing.md:58: $ build/android/adb_chrome_public_command_line --no-sandbox On 2016/02/11 12:04:55, Primiano Tucci wrote: > no need of --no-sandbox Done. https://codereview.chromium.org/1688043004/diff/1/components/tracing/docs/mem... components/tracing/docs/memory_infra_startup_tracing.md:61: $ clank/bin/adb_run_chrome # Googlers only. On 2016/02/11 12:04:55, Primiano Tucci wrote: > ditto Done (ditto). https://codereview.chromium.org/1688043004/diff/1/components/tracing/docs/mem... components/tracing/docs/memory_infra_startup_tracing.md:66: Android (e.g. "/storage/emulated/legacy/Download/trace.json"). Note that startup On 2016/02/11 12:04:55, Primiano Tucci wrote: > /sdcard Done. https://codereview.chromium.org/1688043004/diff/20001/components/tracing/docs... File components/tracing/docs/memory_infra_startup_tracing.md (right): https://codereview.chromium.org/1688043004/diff/20001/components/tracing/docs... components/tracing/docs/memory_infra_startup_tracing.md:25: Note that startup tracing will be enabled upon every Chrome launch until you I realized that I should add the note about disabling startup tracing on Android to the first section as well.
Great thanks P.S. for documentation change I think TBR owners is reasonable. IMHO doc changes are not worth event the trouble of the extra email spam for owners.
Description was changed from ========== [docs] Document MemoryInfra startup tracing on Android Follow-up for: https://codereview.chromium.org/1601523007 ========== to ========== [docs] Document MemoryInfra startup tracing on Android Follow-up for: https://codereview.chromium.org/1601523007 TBR=simonhatch@chromium.org ==========
The CQ bit was checked by petrcermak@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org Link to the patchset: https://codereview.chromium.org/1688043004/#ps20001 (title: "Address Primiano's comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688043004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688043004/20001
Message was sent while issue was closed.
Description was changed from ========== [docs] Document MemoryInfra startup tracing on Android Follow-up for: https://codereview.chromium.org/1601523007 TBR=simonhatch@chromium.org ========== to ========== [docs] Document MemoryInfra startup tracing on Android Follow-up for: https://codereview.chromium.org/1601523007 TBR=simonhatch@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [docs] Document MemoryInfra startup tracing on Android Follow-up for: https://codereview.chromium.org/1601523007 TBR=simonhatch@chromium.org ========== to ========== [docs] Document MemoryInfra startup tracing on Android Follow-up for: https://codereview.chromium.org/1601523007 TBR=simonhatch@chromium.org Committed: https://crrev.com/090678c8ee6fdce2923ee535da5aadc5890ffbe6 Cr-Commit-Position: refs/heads/master@{#374890} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/090678c8ee6fdce2923ee535da5aadc5890ffbe6 Cr-Commit-Position: refs/heads/master@{#374890} |
