scripts/tools/unittests/mastermap_test.py - Issue 1688043003: Move master_port_alts from 40000 to 25000 so they don't overlap with ephemeral ports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/tools/unittests/mastermap_test.py

Issue 1688043003: Move master_port_alts from 40000 to 25000 so they don't overlap with ephemeral ports (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Fix mastermap.py Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/tools/unittests/mastermap_test.py

diff --git a/scripts/tools/unittests/mastermap_test.py b/scripts/tools/unittests/mastermap_test.py

index 38da7250250b9c8d64ea9e26707da4f0e31f28b2..ed58d9d442785668df3983a15d4a6b07c29923e3 100755

--- a/scripts/tools/unittests/mastermap_test.py

+++ b/scripts/tools/unittests/mastermap_test.py

@@ -105,7 +105,7 @@ class FindPortTest(unittest.TestCase):

self.assertEquals(output.data, [ {

u'master_base_class': u'Master1',

u'master_port': u'20105',

- u'master_port_alt': u'40105',

+ u'master_port_alt': u'25105',

u'slave_port': u'30105',

} ])

@@ -115,7 +115,7 @@ class FindPortTest(unittest.TestCase):

output = FakeOutput()

_real_blacklist = mastermap.PORT_BLACKLIST

try:

- mastermap.PORT_BLACKLIST = set(xrange(40000, 50000)) # All alt_ports

+ mastermap.PORT_BLACKLIST = set(xrange(25000, 30000)) # All alt_ports

self.assertRaises(RuntimeError, mastermap.find_port,

master_class_name, masters, output, FakeOpts())

finally:

« no previous file with comments | « scripts/tools/mastermap.py ('k') | site_config/config_default.py » ('j') | site_config/config_default.py » ('J')