Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1688043003: Move master_port_alts from 40000 to 25000 so they don't overlap with ephemeral ports (Closed)

Created:
4 years, 10 months ago by dsansome
Modified:
4 years, 10 months ago
Reviewers:
dnj, dnj (Google)
CC:
chromium-reviews, infra-reviews+build_chromium.org, friedman
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Move master_port_alts from 40000 to 25000 so they don't overlap with ephemeral ports BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298872

Patch Set 1 #

Patch Set 2 : Reorder some lines #

Patch Set 3 : Fix mastermap.py #

Total comments: 2

Patch Set 4 : Raise an exception if asked to compose a port outside the range #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -52 lines) Patch
M masters/master.chromium.android/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium.goma/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium.mojo/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium.tools.build/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.client.boringssl/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.client.catapult/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.client.crashpad/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.client.fletch/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.client.flutter/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.client.gyp/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.client.legion/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.client.ndk/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.client.pdfium/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.client.wasm.llvm/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.chromium.android/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.chromium.angle/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.client.catapult/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.client.custom_tabs_client/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.client.mojo/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.client.syzygy/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.infra/master_site_config.py View 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/tools/mastermap.py View 1 2 5 chunks +14 lines, -13 lines 0 comments Download
M scripts/tools/unittests/mastermap_test.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M site_config/config_default.py View 1 2 3 3 chunks +36 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dsansome
4 years, 10 months ago (2016-02-11 04:36:38 UTC) #2
dnj (Google)
lgtm. Make sure you coordinate with labs and issue a restart for affected master. Probably ...
4 years, 10 months ago (2016-02-12 01:10:06 UTC) #4
dsansome
https://codereview.chromium.org/1688043003/diff/40001/site_config/config_default.py File site_config/config_default.py (right): https://codereview.chromium.org/1688043003/diff/40001/site_config/config_default.py#newcode34 site_config/config_default.py:34: def contains(self, port): On 2016/02/12 01:10:06, dnj (Google) wrote: ...
4 years, 10 months ago (2016-02-12 02:29:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688043003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688043003/50001
4 years, 10 months ago (2016-02-19 02:14:53 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 02:18:26 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:50001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298872

Powered by Google App Engine
This is Rietveld 408576698