Add chromium_clang_upload bot for Linux.

Add chromium_clang_upload bot for Linux.

Right now, it checks out Chromium + the deps for Android and calls tools/clang/scripts/package.py with no parameters.

The next step will be to allow package.py to upload the binaries to Google Cloud Storage, if --upload-binaries is specified, and then make the bot to pass this flag.

BUG=578306
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298751

[krasin1, 2016-02-10 22:41:48]

Description was changed from

==========
Add chromium_clang_upload bot for Linux.

It's not fully functional yet, but all basic parts are placed.

BUG=578306
==========

to

==========
Add chromium_clang_upload bot for Linux.

It's not fully functional yet, but all basic parts are placed.

BUG=578306
==========

[krasin1, 2016-02-11 00:26:49]

Description was changed from

==========
Add chromium_clang_upload bot for Linux.

It's not fully functional yet, but all basic parts are placed.

BUG=578306
==========

to

==========
Add chromium_clang_upload bot for Linux.

Right now, it checks out Chromium + the deps for Android and calls
tools/clang/scripts/package.py with no parameters.

The next step will be to allow package.py to upload the binaries to Google Cloud
Storage, if --upload-binaries is specified, and then make the bot to pass this
flag.

BUG=578306
==========

[krasin1, 2016-02-11 00:33:41]

Patchset #1 (id:1) has been deleted

[krasin1, 2016-02-11 00:33:47]

Patchset #1 (id:20001) has been deleted

[krasin1, 2016-02-11 00:34:54]

krasin@chromium.org changed reviewers:
+ hans@chromium.org, krasin@chromium.org, thakis@chromium.org

[Nico, 2016-02-11 00:39:53]

thakis@chromium.org changed reviewers:
+ dpranke@chromium.org

[Nico, 2016-02-11 00:39:53]

Dirk, this is modeled after your excellent gn rolling bots. Can you take a quick
look we didn't miss anything obvious?

This looks exactly like I thought it would, so if Dirk is happy I'm happy with
this too.

https://codereview.chromium.org/1688043002/diff/40001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium_clang_upload.py (right):

https://codereview.chromium.org/1688043002/diff/40001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium_clang_upload.py:55: 
nit: style guide says two blank lines between toplevel things

[krasin1, 2016-02-11 00:46:39]

https://codereview.chromium.org/1688043002/diff/40001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium_clang_upload.py (right):

https://codereview.chromium.org/1688043002/diff/40001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium_clang_upload.py:55: 
On 2016/02/11 00:39:53, Nico wrote:
> nit: style guide says two blank lines between toplevel things

Done.

[hans, 2016-02-11 00:46:48]

Looks fine to me to, but I'll let Nico and/or Dirk sign off since they know the
buildbot stuff better than me.

[Dirk Pranke, 2016-02-11 01:26:07]

lgtm w/ a couple nits.

You probably need a src-side change to add the bot to //tools/mb/mb_config.pyl,
yes?

https://codereview.chromium.org/1688043002/diff/60001/masters/master.tryserve...
File masters/master.tryserver.chromium.linux/master.cfg (right):

https://codereview.chromium.org/1688043002/diff/60001/masters/master.tryserve...
masters/master.tryserver.chromium.linux/master.cfg:235: # bots need the Android
build dependencies.
nit: I don't know that I would bother w/ the comment about not reusing the
slavebuilddir; I won't by default expect you to.

https://codereview.chromium.org/1688043002/diff/60001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium_clang_upload.py (right):

https://codereview.chromium.org/1688043002/diff/60001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium_clang_upload.py:43: ['mb'])
nit: did you really need to wrap this line?

[krasin1, 2016-02-11 18:02:56]

All done.

The src part of the change is uploaded:
https://codereview.chromium.org/1692583002

https://codereview.chromium.org/1688043002/diff/60001/masters/master.tryserve...
File masters/master.tryserver.chromium.linux/master.cfg (right):

https://codereview.chromium.org/1688043002/diff/60001/masters/master.tryserve...
masters/master.tryserver.chromium.linux/master.cfg:235: # bots need the Android
build dependencies.
On 2016/02/11 01:26:07, Dirk Pranke wrote:
> nit: I don't know that I would bother w/ the comment about not reusing the
> slavebuilddir; I won't by default expect you to.

Done.

https://codereview.chromium.org/1688043002/diff/60001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium_clang_upload.py (right):

https://codereview.chromium.org/1688043002/diff/60001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium_clang_upload.py:43: ['mb'])
On 2016/02/11 01:26:07, Dirk Pranke wrote:
> nit: did you really need to wrap this line?

Not really. :)

[krasin1, 2016-02-12 01:33:08]

The CQ bit was checked by krasin@chromium.org

[krasin1, 2016-02-12 01:33:08]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1688043002/#ps80001
(title: "nits")

[commit-bot: I haz the power, 2016-02-12 01:33:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1688043002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1688043002/80001

[commit-bot: I haz the power, 2016-02-12 01:36:44]

Description was changed from

==========
Add chromium_clang_upload bot for Linux.

Right now, it checks out Chromium + the deps for Android and calls
tools/clang/scripts/package.py with no parameters.

The next step will be to allow package.py to upload the binaries to Google Cloud
Storage, if --upload-binaries is specified, and then make the bot to pass this
flag.

BUG=578306
==========

to

==========
Add chromium_clang_upload bot for Linux.

Right now, it checks out Chromium + the deps for Android and calls
tools/clang/scripts/package.py with no parameters.

The next step will be to allow package.py to upload the binaries to Google Cloud
Storage, if --upload-binaries is specified, and then make the bot to pass this
flag.

BUG=578306

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298751
==========

[commit-bot: I haz the power, 2016-02-12 01:36:44]

Committed patchset #3 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298751