Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1692583002: Add linux_chromium_clang_upload bot (src part). (Closed)

Created:
4 years, 10 months ago by krasin
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add linux_chromium_clang_upload bot (src part). BUG=578306 Committed: https://crrev.com/6dd9369878ac6f0c5d20bf8efca44da113cf725c Cr-Commit-Position: refs/heads/master@{#375062}

Patch Set 1 : . #

Total comments: 4

Patch Set 2 : gn_release_bot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/mb/mb_config.pyl View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
krasin1
4 years, 10 months ago (2016-02-11 18:03:16 UTC) #2
krasin1
Hi Dirk, can you please take a look at this one-liner? This is the src/ ...
4 years, 10 months ago (2016-02-11 20:40:40 UTC) #4
krasin1
2-liner, I mean. :)
4 years, 10 months ago (2016-02-11 20:40:52 UTC) #5
Dirk Pranke
lgtm if you change your patch almost completely :). https://codereview.chromium.org/1692583002/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1692583002/diff/20001/tools/mb/mb_config.pyl#newcode31 tools/mb/mb_config.pyl:31: ...
4 years, 10 months ago (2016-02-11 20:52:16 UTC) #7
krasin1
The patch has been changed almost completely, as requested. :) https://codereview.chromium.org/1692583002/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1692583002/diff/20001/tools/mb/mb_config.pyl#newcode31 ...
4 years, 10 months ago (2016-02-11 22:26:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692583002/40001
4 years, 10 months ago (2016-02-11 22:27:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-12 00:40:35 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:40:06 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6dd9369878ac6f0c5d20bf8efca44da113cf725c
Cr-Commit-Position: refs/heads/master@{#375062}

Powered by Google App Engine
This is Rietveld 408576698