Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: src/frames.cc

Issue 1688023003: Remove the JS_FRAME_FUNCTION deoptimizer translation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/deoptimizer.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index 47b4a1b3249bddb9fe886b38d760610596682abb..77713bae7c4eca53d6ab8617f35ff285e9fc9580 100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -969,11 +969,9 @@ void OptimizedFrame::Summarize(List<FrameSummary>* frames) {
JSFunction* function;
if (opcode == Translation::LITERAL) {
function = JSFunction::cast(literal_array->get(it.Next()));
- } else if (opcode == Translation::STACK_SLOT) {
- function = JSFunction::cast(StackSlotAt(it.Next()));
} else {
- CHECK_EQ(Translation::JS_FRAME_FUNCTION, opcode);
- function = this->function();
+ CHECK_EQ(opcode, Translation::STACK_SLOT);
+ function = JSFunction::cast(StackSlotAt(it.Next()));
}
DCHECK_EQ(shared_info, function->shared());
@@ -987,8 +985,6 @@ void OptimizedFrame::Summarize(List<FrameSummary>* frames) {
receiver = literal_array->get(it.Next());
} else if (opcode == Translation::STACK_SLOT) {
receiver = StackSlotAt(it.Next());
- } else if (opcode == Translation::JS_FRAME_FUNCTION) {
- receiver = this->function();
} else {
// The receiver is not in a stack slot nor in a literal. We give up.
it.Skip(Translation::NumberOfOperandsFor(opcode));
@@ -1112,11 +1108,9 @@ void OptimizedFrame::GetFunctions(List<JSFunction*>* functions) const {
Object* function;
if (opcode == Translation::LITERAL) {
function = literal_array->get(it.Next());
- } else if (opcode == Translation::STACK_SLOT) {
- function = StackSlotAt(it.Next());
} else {
- CHECK_EQ(Translation::JS_FRAME_FUNCTION, opcode);
- function = this->function();
+ CHECK_EQ(Translation::STACK_SLOT, opcode);
+ function = StackSlotAt(it.Next());
}
functions->Add(JSFunction::cast(function));
}
« no previous file with comments | « src/deoptimizer.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698