Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1688023003: Remove the JS_FRAME_FUNCTION deoptimizer translation. (Closed)

Created:
4 years, 10 months ago by Jarin
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove the JS_FRAME_FUNCTION deoptimizer translation. JS_FRAME_FUNCTION can be expressed using the STACK_SLOT translation. Committed: https://crrev.com/6de51c4dc7167268d59bf25f20ac03e21feea9d7 Cr-Commit-Position: refs/heads/master@{#33882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -34 lines) Patch
M src/deoptimizer.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/deoptimizer.cc View 3 chunks +3 lines, -15 lines 0 comments Download
M src/frames.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 10 months ago (2016-02-11 08:02:40 UTC) #2
Benedikt Meurer
LGTM!
4 years, 10 months ago (2016-02-11 08:05:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688023003/1
4 years, 10 months ago (2016-02-11 08:17:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 08:24:46 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 10:41:08 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6de51c4dc7167268d59bf25f20ac03e21feea9d7
Cr-Commit-Position: refs/heads/master@{#33882}

Powered by Google App Engine
This is Rietveld 408576698