Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: net/quic/quic_spdy_stream.h

Issue 1688003005: QUIC - instrumentation for testing null QuicSpdyStream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add more instrumentation Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_spdy_stream.h
diff --git a/net/quic/quic_spdy_stream.h b/net/quic/quic_spdy_stream.h
index d47d9d834cfeee91aaef4ca028070f9e8d0f46b7..c78db875705b6ee6bcf6d3992655ecac7f994fa7 100644
--- a/net/quic/quic_spdy_stream.h
+++ b/net/quic/quic_spdy_stream.h
@@ -15,6 +15,15 @@
#include <list>
#include <string>
+// TODO(rtenneti): Temporary while investigating crbug.com/585591.
+// Note base::Debug::StackTrace() is not supported in NACL
+// builds so conditionally disabled it there.
+#include "build/build_config.h"
+#ifndef OS_NACL
+#define TEMP_INSTRUMENTATION_585591
+#include "base/debug/stack_trace.h"
+#endif
+
#include "base/macros.h"
#include "base/strings/string_piece.h"
#include "net/base/iovec.h"
@@ -151,6 +160,10 @@ class NET_EXPORT_PRIVATE QuicSpdyStream : public ReliableQuicStream {
// written to the server.
void SetPriority(SpdyPriority priority);
+ // TODO(rtenneti): Temporary until crbug.com/585591 is solved.
+ void CrashIfInvalid() const;
+ void set_read_is_called(bool value) { read_is_called_ = value; }
+
protected:
// Called by OnStreamHeadersComplete depending on which type (initial or
// trailing) headers are expected next.
@@ -167,6 +180,12 @@ class NET_EXPORT_PRIVATE QuicSpdyStream : public ReliableQuicStream {
friend class test::ReliableQuicStreamPeer;
friend class QuicStreamUtils;
+ // TODO(rtenneti): Temporary until crbug.com/585591 is solved.
+ enum Liveness {
+ ALIVE = 0xCA11AB13,
+ DEAD = 0xDEADBEEF,
+ };
+
// Returns true if trailers have been fully read and consumed.
bool FinishedReadingTrailers() const;
@@ -187,6 +206,15 @@ class NET_EXPORT_PRIVATE QuicSpdyStream : public ReliableQuicStream {
// via ProcessData or Readv.
std::string decompressed_trailers_;
+ // TODO(rtenneti): Temporary until crbug.com/585591 is solved.
+ Liveness liveness_ = ALIVE;
+ bool read_is_called_ = false;
+
+// TODO(rtenneti): Temporary while investigating crbug.com/585591.
+#ifdef TEMP_INSTRUMENTATION_585591
+ base::debug::StackTrace stack_trace_;
+#endif
+
DISALLOW_COPY_AND_ASSIGN(QuicSpdyStream);
};

Powered by Google App Engine
This is Rietveld 408576698