QUIC - instrumentation for testing null QuicSpdyStream.

net/quic/quic_spdy_stream.cc

Index: net/quic/quic_spdy_stream.cc
diff --git a/net/quic/quic_spdy_stream.cc b/net/quic/quic_spdy_stream.cc
index bcb9dc1737003f79333ce5c962f2ce04dbc36164..8c6f7d35c2a6d5b476ee14d993d7d879f61f2986 100644
--- a/net/quic/quic_spdy_stream.cc
+++ b/net/quic/quic_spdy_stream.cc
@@ -4,6 +4,10 @@
 
 #include "net/quic/quic_spdy_stream.h"
 
+// TODO(rtenneti): Temporary while investigating crbug.com/585591.
+#ifdef TEMP_INSTRUMENTATION_585591
+#include "base/debug/alias.h"
+#endif
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "net/quic/quic_bug_tracker.h"
@@ -37,6 +41,25 @@ QuicSpdyStream::QuicSpdyStream(QuicStreamId id, QuicSpdySession* spdy_session)
 
 QuicSpdyStream::~QuicSpdyStream() {
   spdy_session_->UnregisterStreamPriority(id());
+  // TODO(rtenneti): Temporary until crbug.com/585591 is solved.
+  liveness_ = DEAD;
+#ifdef TEMP_INSTRUMENTATION_585591
+  stack_trace_ = base::debug::StackTrace();
+  // Probably not necessary, but just in case compiler tries to optimize out
+  // the writes to stack_trace_.
+  base::debug::Alias(&stack_trace_);
+  // Get callstack, if the object is going away and we are doing a Read().
+  CHECK(!read_is_called_);
+#endif
+}
+
+// TODO(rtenneti): Temporary until crbug.com/585591 is solved.
+void QuicSpdyStream::CrashIfInvalid() const {

[eroman, 2016/02/12 01:42:46]

I believe you want to either copy stack_trace_ to the stack here, or remove
stack_trace_ alltogether.

stack_trace_ contains the deletion callstack, but based on what is being test I
would expect the CHECK() in the dtor to get hit if we delete it during the
Read(), meaning less useful to have it here.

[ramant (doing other things), 2016/02/12 02:47:09]

+1. Removed the stack_trace_.

Done.

+  Liveness liveness = liveness_;
+  if (liveness == ALIVE)
+    return;
+  base::debug::Alias(&liveness);
+  CHECK_EQ(ALIVE, liveness);
 }
 
 void QuicSpdyStream::CloseWriteSide() {