Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: third_party/WebKit/PRESUBMIT.py

Issue 1687803002: Expand WebEmbeddedWorkerImplTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/PRESUBMIT.py
diff --git a/third_party/WebKit/PRESUBMIT.py b/third_party/WebKit/PRESUBMIT.py
index ca89625707527930245d17f28f2dd4f9d588bfc8..8d073343a52f62e7880fe77effdc74e4692f894d 100644
--- a/third_party/WebKit/PRESUBMIT.py
+++ b/third_party/WebKit/PRESUBMIT.py
@@ -175,11 +175,11 @@ def _CheckForDangerousTestFunctions(input_api, output_api):
input_api, None)
errors = [' * %s' % violation for violation in errors]
if errors:
- return [output_api.PresubmitError(
- 'You should be using FrameTestHelpers::'
- 'pumpPendingRequests() instead of '
- 'serveAsynchronousMockedRequests() in the following '
- 'locations:\n%s' % '\n'.join(errors))]
+ return [output_api.PresubmitPromptOrNotify(
+ 'You should probably be using one of the FrameTestHelpers::'
+ '(re)load* functions instead of '
+ 'serveAsynchronousMockedRequests() in the following '
+ 'locations:\n%s' % '\n'.join(errors))]
return []
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698