Expand WebEmbeddedWorkerImplTest

third_party/WebKit/PRESUBMIT.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Blink.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 157 matching lines @@
 def _CheckForDangerousTestFunctions(input_api, output_api):
     """Tests should not be using serveAsynchronousMockedRequests, since it does
     not guarantee that the threaded HTML parser will have completed."""
     serve_async_requests_re = input_api.re.compile(
         r'serveAsynchronousMockedRequests')
     errors = input_api.canned_checks._FindNewViolationsOfRule(
         lambda _, x: not serve_async_requests_re.search(x),
         input_api, None)
     errors = ['  * %s' % violation for violation in errors]
     if errors:
-        return [output_api.PresubmitError(
-                    'You should be using FrameTestHelpers::'
-                    'pumpPendingRequests() instead of '
-                    'serveAsynchronousMockedRequests() in the following '
-                    'locations:\n%s' % '\n'.join(errors))]
+        return [output_api.PresubmitPromptOrNotify(
+            'You should probably be using one of the FrameTestHelpers::'
+            '(re)load* functions instead of '
+            'serveAsynchronousMockedRequests() in the following '
+            'locations:\n%s' % '\n'.join(errors))]
     return []
 
 
 def _CheckForFailInFile(input_api, f):
     pattern = input_api.re.compile('^FAIL')
     errors = []
     for line_num, line in f.ChangedContents():
         if pattern.match(line):
             errors.append('    %s:%d %s' % (f.LocalPath(), line_num, line))
     return errors
@@ skipping 103 matching lines @@
     for master in masters:
         try_config.setdefault(master, {})
         for builder in masters[master]:
             # Do not trigger presubmit builders, since they're likely to fail
             # (e.g. OWNERS checks before finished code review), and we're
             # running local presubmit anyway.
             if 'presubmit' not in builder:
                 try_config[master][builder] = ['defaulttests']
 
     return try_config