Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 16878003: Make sure GCMole pukes when Clang invocation fails. (Closed)

Created:
7 years, 6 months ago by Michael Starzinger
Modified:
7 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Make sure GCMole pukes when Clang invocation fails. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/gcmole/gcmole.lua View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 6 months ago (2013-06-17 17:00:24 UTC) #1
Jakob Kummerow
lgtm
7 years, 6 months ago (2013-06-17 17:20:02 UTC) #2
Michael Starzinger
7 years, 6 months ago (2013-06-17 18:00:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15187 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698