tools/gcmole/gcmole.lua - Issue 16878003: Make sure GCMole pukes when Clang invocation fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gcmole/gcmole.lua

Issue 16878003: Make sure GCMole pukes when Clang invocation fails. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gcmole/gcmole.lua

diff --git a/tools/gcmole/gcmole.lua b/tools/gcmole/gcmole.lua

index b259ee014319a1b26a74efcc57c05786c78c7cab..66aff942a49927a20fbc0a24e58f3d1e6de4b481 100644

--- a/tools/gcmole/gcmole.lua

+++ b/tools/gcmole/gcmole.lua

@@ -117,7 +117,8 @@ function InvokeClangPluginForEachFile(filenames, cfg, func)

if FLAGS.verbose then print('popen ', action) end

local pipe = io.popen(action)

func(filename, pipe:lines())

- pipe:close()

+ local success = pipe:close()

+ if not success then error("Failed to run: " .. action) end

end

« no previous file with comments | « no previous file | no next file » | no next file with comments »