pkg/analyzer/lib/src/summary/summarize_ast.dart - Issue 1687793003: Remove irrelevant TODOs from summary code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/summary/summarize_ast.dart

Issue 1687793003: Remove irrelevant TODOs from summary code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/summary/summarize_ast.dart

diff --git a/pkg/analyzer/lib/src/summary/summarize_ast.dart b/pkg/analyzer/lib/src/summary/summarize_ast.dart

index e43e2e1058ec8ba344111bb9735b509c4a75b7a3..fdc5b05150b13b98f64cd4532a61608798cd1b28 100644

--- a/pkg/analyzer/lib/src/summary/summarize_ast.dart

+++ b/pkg/analyzer/lib/src/summary/summarize_ast.dart

@@ -303,8 +303,6 @@ class _SummarizeAstVisitor extends SimpleAstVisitor {

String className, NodeList<ClassMember> members) {

_Scope scope = new _Scope();

for (ClassMember member in members) {

- // TODO(paulbery): consider replacing these if-tests with dynamic method

- // dispatch.

if (member is MethodDeclaration) {

if (member.isSetter || member.isOperator) {

// We don't have to handle setters or operators because the only