Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc

Issue 1687353002: Force time elapsed queries on certain drivers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/gpu_tracer_unittest.cc » ('j') | ui/gl/gpu_timing.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
index 8650c9d64842cd7eb39e1227d75dee493e4592ca..e2ececeeb2c6b94f7fc16850f4066ddbf6d28553 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
@@ -704,10 +704,9 @@ static void CheckBeginEndQueryBadMemoryFails(GLES2DecoderTestBase* test,
error::Error error1 = error::kNoError;
error::Error error2 = error::kNoError;
if (query_type.is_counter) {
- error1 = ExecuteQueryCounterCmd(test, gl, &gpu_timing_queries,
- query_type.type,
- client_id, service_id,
- shm_id, shm_offset, 1);
+ error1 =
+ ExecuteQueryCounterCmd(test, gl, &gpu_timing_queries, query_type.type,
+ client_id, service_id, shm_id, shm_offset, 1);
} else {
error1 = ExecuteBeginQueryCmd(test, gl, &gpu_timing_queries,
query_type.type,
@@ -777,14 +776,11 @@ TEST_P(GLES2DecoderManualInitTest, QueryReuseTest) {
// Query once.
if (query_type.is_counter) {
- EXPECT_EQ(error::kNoError, ExecuteQueryCounterCmd(this, gl,
- &gpu_timing_queries,
- query_type.type,
- kNewClientId,
- kNewServiceId,
- kSharedMemoryId,
- kSharedMemoryOffset,
- 1));
+ EXPECT_EQ(
+ error::kNoError,
+ ExecuteQueryCounterCmd(this, gl, &gpu_timing_queries, query_type.type,
+ kNewClientId, kNewServiceId, kSharedMemoryId,
+ kSharedMemoryOffset, 1));
} else {
EXPECT_EQ(error::kNoError, ExecuteBeginQueryCmd(this, gl,
&gpu_timing_queries,
@@ -801,14 +797,11 @@ TEST_P(GLES2DecoderManualInitTest, QueryReuseTest) {
// Reuse query.
if (query_type.is_counter) {
- EXPECT_EQ(error::kNoError, ExecuteQueryCounterCmd(this, gl,
- &gpu_timing_queries,
- query_type.type,
- kNewClientId,
- kNewServiceId,
- kSharedMemoryId,
- kSharedMemoryOffset,
- 2));
+ EXPECT_EQ(
+ error::kNoError,
+ ExecuteQueryCounterCmd(this, gl, &gpu_timing_queries, query_type.type,
+ kNewClientId, kNewServiceId, kSharedMemoryId,
+ kSharedMemoryOffset, 2));
} else {
EXPECT_EQ(error::kNoError, ExecuteBeginQueryCmd(this, gl,
&gpu_timing_queries,
@@ -1029,6 +1022,9 @@ TEST_P(GLES2DecoderManualInitTest, QueryCounterEXTTimeStamp) {
EXPECT_CALL(*gl_, GenQueries(1, _))
.WillOnce(SetArgPointee<1>(kNewServiceId))
.RetiresOnSaturation();
+ EXPECT_CALL(*gl_, GetQueryiv(GL_TIMESTAMP, GL_QUERY_COUNTER_BITS, _))
+ .WillOnce(SetArgPointee<2>(64))
+ .RetiresOnSaturation();
EXPECT_CALL(*gl_, QueryCounter(kNewServiceId, GL_TIMESTAMP))
.Times(1)
.RetiresOnSaturation();
« no previous file with comments | « no previous file | gpu/command_buffer/service/gpu_tracer_unittest.cc » ('j') | ui/gl/gpu_timing.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698