Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1687293003: Rewrite asyncStepOver to use await (Closed)

Created:
4 years, 10 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rewrite asyncStepOver to use await - Add some documentation and use await instead of .then() in asyncStepOver. - Analyzer fixes to service lib and tests. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/6b22d8e97cafd6c239d3f0ceb1800fa728cd9f07

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -49 lines) Patch
M runtime/observatory/lib/object_graph.dart View 4 chunks +1 line, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 4 chunks +58 lines, -35 lines 0 comments Download
M runtime/observatory/tests/service/async_next_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/get_object_rpc_test.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/smart_next_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 10 months ago (2016-02-11 21:04:03 UTC) #3
rmacnak
lgtm
4 years, 10 months ago (2016-02-11 21:16:51 UTC) #4
Cutch
4 years, 10 months ago (2016-02-11 22:19:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6b22d8e97cafd6c239d3f0ceb1800fa728cd9f07 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698