runtime/observatory/lib/src/elements/debugger.dart - Issue 1687293003: Rewrite asyncStepOver to use await

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/debugger.dart

Issue 1687293003: Rewrite asyncStepOver to use await (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/elements/debugger.dart

diff --git a/runtime/observatory/lib/src/elements/debugger.dart b/runtime/observatory/lib/src/elements/debugger.dart

index 06f91e799d14e4d6da8ff17950d752789b54e5ed..3692d6a50c1c3cd1c85729be4d61f154c3ec3bac 100644

--- a/runtime/observatory/lib/src/elements/debugger.dart

+++ b/runtime/observatory/lib/src/elements/debugger.dart

@@ -1826,7 +1826,8 @@ class ObservatoryDebugger extends Debugger {

if (event.asyncContinuation == null) {

console.print("No async continuation at this location");

} else {

- return isolate.asyncStepOver()[Isolate.kFirstResume];

+ List<Future> asyncStepFutures = await isolate.asyncStepOver();

+ return asyncStepFutures[Isolate.kFirstResume];

}

} else {

console.print('The program is already running');