Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1687243002: Revert of [libphonenumber] Change DEPS to track new github mirror, uprev library (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mkwst+moarreviews-renderer_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [libphonenumber] Change DEPS to track new github mirror, uprev library (patchset #6 id:200001 of https://codereview.chromium.org/1674373003/ ) Reason for revert: Needs some tweaks to build on clang/win, see comment 24. (Checked with mathp on chat.) Original issue's description: > [libphonenumber] Change DEPS to track new github mirror, uprev library > > Changes to build files and include paths. > > BUG=585286, 585244 > TBR=tedchoc TBR=rouslan@chromium.org,tedchoc@chromium.org,mathp@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585286, 585244 Committed: https://crrev.com/64ec2081e698c94ae4bf34d1107cee9a5d3b9ea2 Cr-Commit-Position: refs/heads/master@{#374844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -85 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +7 lines, -2 lines 0 comments Download
M components/autofill/core/browser/phone_number_i18n.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/phone_number_i18n_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/android/phone_number_detector.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/libphonenumber/BUILD.gn View 4 chunks +29 lines, -29 lines 0 comments Download
M third_party/libphonenumber/README.chromium View 2 chunks +13 lines, -5 lines 0 comments Download
M third_party/libphonenumber/libphonenumber.gyp View 5 chunks +30 lines, -30 lines 0 comments Download
D third_party/libphonenumber/phonenumber_api.h View 1 chunk +0 lines, -13 lines 0 comments Download
A third_party/libphonenumber/src/phonenumber_api.h View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Revert of [libphonenumber] Change DEPS to track new github mirror, uprev library
4 years, 10 months ago (2016-02-11 02:44:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687243002/1
4 years, 10 months ago (2016-02-11 02:44:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 02:46:04 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:34:18 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64ec2081e698c94ae4bf34d1107cee9a5d3b9ea2
Cr-Commit-Position: refs/heads/master@{#374844}

Powered by Google App Engine
This is Rietveld 408576698