Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2018)

Unified Diff: third_party/libphonenumber/README.chromium

Issue 1687243002: Revert of [libphonenumber] Change DEPS to track new github mirror, uprev library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libphonenumber/BUILD.gn ('k') | third_party/libphonenumber/libphonenumber.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libphonenumber/README.chromium
diff --git a/third_party/libphonenumber/README.chromium b/third_party/libphonenumber/README.chromium
index 54e43d80fc95a721c3ea728a3539ba0178f589f5..23d69328cd7f7dd75ea68612b3d25dc5de927bc1 100644
--- a/third_party/libphonenumber/README.chromium
+++ b/third_party/libphonenumber/README.chromium
@@ -1,13 +1,14 @@
Name: International Phone Number Library
Short Name: libphonenumber
-URL: https://github.com/googlei18n/libphonenumber
+URL: http://libphonenumber.googlecode.com/svn/trunk/
Version: unknown
-Revision: a9bd368debe74355364965c24bcc5a6bfb1dc546
+Revision: 584
License: Apache 2.0
License File: LICENSE
Security Critical: yes
-This directory contains the source code of International Phone Number Library.
+This directory contains the source code of International Phone Number Library
+for C/C++.
This library depends on
- third_party/icu for internationalisation, UTF8-16-32 conversion and regular
@@ -15,11 +16,18 @@
- third_party/protobuf Lite version.
Additional files, not in the original library:
- BUILD.gn
libphonenumber.gyp
README.chromium
LICENSE # Taken from https://github.com/googlei18n/libphonenumber/
- phonenumber_api.h
+ src/phonenumber_api.h
+
+The library is mapped through the DEPS file into src/ folder. To update:
+1. Get the latest version number from
+ http://code.google.com/p/libphonenumber/source/list
+2. Locally update this file and DEPS.
+3. run 'gclient sync'
+4. Adjust libphonenumber.gyp if necessary.
+5. Verify that all compiles and all of the tests are successfull.
WARNING: This library is only thread-safe on POSIX. This means that
PhoneNumberUtil and the other singletons should be accessed from a single
« no previous file with comments | « third_party/libphonenumber/BUILD.gn ('k') | third_party/libphonenumber/libphonenumber.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698