|
|
Created:
6 years, 10 months ago by msw Modified:
6 years, 10 months ago Reviewers:
sky CC:
chromium-reviews, tfarina Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionFix RTL UI extension popup anchoring.
BubbleDelegateView::CreateNonClientFrameView mirrors in RTL.
(arrow horizontal positions/anchoring are flipped in RTL UI)
BrowserActionsContainer::ShowPopup should not do the same.
See before and after pictures at http://crbug.com/150696
BUG=150696
TEST=RTL (--lang=he) UI browser/page action extension popups should be anchored at the top left and shouldn't be cut off.
R=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251998
Patch Set 1 #
Messages
Total messages: 21 (0 generated)
Hey Scott, please take a look; thanks!
LGTM
The CQ bit was checked by msw@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/168723004/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by msw@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/168723004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel
The CQ bit was checked by msw@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/168723004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel
The CQ bit was checked by msw@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/168723004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel
The CQ bit was checked by msw@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/168723004/1
Message was sent while issue was closed.
Change committed as 251998 |