Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 168723004: Fix RTL UI extension popup anchoring. (Closed)

Created:
6 years, 10 months ago by msw
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix RTL UI extension popup anchoring. BubbleDelegateView::CreateNonClientFrameView mirrors in RTL. (arrow horizontal positions/anchoring are flipped in RTL UI) BrowserActionsContainer::ShowPopup should not do the same. See before and after pictures at http://crbug.com/150696 BUG=150696 TEST=RTL (--lang=he) UI browser/page action extension popups should be anchored at the top left and shouldn't be cut off. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
msw
Hey Scott, please take a look; thanks!
6 years, 10 months ago (2014-02-18 23:59:24 UTC) #1
sky
LGTM
6 years, 10 months ago (2014-02-19 00:54:11 UTC) #2
msw
The CQ bit was checked by msw@chromium.org
6 years, 10 months ago (2014-02-19 00:55:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/168723004/1
6 years, 10 months ago (2014-02-19 00:58:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 01:17:07 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=266069
6 years, 10 months ago (2014-02-19 01:17:08 UTC) #6
msw
The CQ bit was checked by msw@chromium.org
6 years, 10 months ago (2014-02-19 01:30:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/168723004/1
6 years, 10 months ago (2014-02-19 01:52:43 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 04:36:24 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-19 04:36:25 UTC) #10
msw
The CQ bit was checked by msw@chromium.org
6 years, 10 months ago (2014-02-19 04:45:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/168723004/1
6 years, 10 months ago (2014-02-19 04:45:53 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 04:46:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-19 04:46:31 UTC) #14
msw
The CQ bit was checked by msw@chromium.org
6 years, 10 months ago (2014-02-19 05:12:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/168723004/1
6 years, 10 months ago (2014-02-19 05:13:16 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 05:13:32 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-19 05:13:33 UTC) #18
msw
The CQ bit was checked by msw@chromium.org
6 years, 10 months ago (2014-02-19 06:40:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/168723004/1
6 years, 10 months ago (2014-02-19 06:40:39 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 08:21:50 UTC) #21
Message was sent while issue was closed.
Change committed as 251998

Powered by Google App Engine
This is Rietveld 408576698