Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6835)

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container.cc

Issue 168723004: Fix RTL UI extension popup anchoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/browser_actions_container.cc
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.cc b/chrome/browser/ui/views/toolbar/browser_actions_container.cc
index eb259644d74e261cc5f5ff16848db0581671432c..e039d522db0cbb7a986263146bec2fa340ca0a3b 100644
--- a/chrome/browser/ui/views/toolbar/browser_actions_container.cc
+++ b/chrome/browser/ui/views/toolbar/browser_actions_container.cc
@@ -860,12 +860,8 @@ bool BrowserActionsContainer::ShowPopup(
// since buttons can be activated from the overflow menu (chevron). In that
// case we show the popup as originating from the chevron.
View* reference_view = button->parent()->visible() ? button : chevron_;
- views::BubbleBorder::Arrow arrow = base::i18n::IsRTL() ?
- views::BubbleBorder::TOP_LEFT : views::BubbleBorder::TOP_RIGHT;
- popup_ = ExtensionPopup::ShowPopup(popup_url,
- browser_,
- reference_view,
- arrow,
+ popup_ = ExtensionPopup::ShowPopup(popup_url, browser_, reference_view,
+ views::BubbleBorder::TOP_RIGHT,
show_action);
popup_->GetWidget()->AddObserver(this);
popup_button_ = button;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698