Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1687033002: Revert of Make text section 2MB aligned for hugepages. (Closed)

Created:
4 years, 10 months ago by stevenjb
Modified:
4 years, 10 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, satorux1, ketakid
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make text section 2MB aligned for hugepages. (patchset #7 id:120001 of https://codereview.chromium.org/1619713007/ ) Reason for revert: Causing failures on x86-alex, peach_pit, and daisy_skate (render process crash in login screen). Original issue's description: > Make text section 2MB aligned for hugepages. > > If we do not use the option '-Wl,--section-start=.text=2001000' at > link time, the performance gain on hugepages is gone. This is probably > because the original text section is not 2MB aligned and the after > mremap, the hugepage is not preserved. > > BUG=chromium:569963 > TEST=The performance gain is back on micro benchmarks. > > Committed: https://crrev.com/1384534a94e6324d74906f0cbc1e707606c063f2 > Cr-Commit-Position: refs/heads/master@{#373673} TBR=rickyz@chromium.org,cmtice@chromium.org,kenchen@google.com,llozano@chromium.org,shenhan@chromium.org,yunlian@chromium.org,yunlian@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:569963 Committed: https://crrev.com/f0aab631c727924fb1ae2ff9e6ba5878c073b717 Cr-Commit-Position: refs/heads/master@{#374687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M chromeos/hugepage_text/hugepage_text.cc View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
stevenjb
Created Revert of Make text section 2MB aligned for hugepages.
4 years, 10 months ago (2016-02-10 16:42:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687033002/1
4 years, 10 months ago (2016-02-10 16:43:45 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/20163) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-10 16:47:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687033002/1
4 years, 10 months ago (2016-02-10 17:34:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 18:08:18 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 18:10:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0aab631c727924fb1ae2ff9e6ba5878c073b717
Cr-Commit-Position: refs/heads/master@{#374687}

Powered by Google App Engine
This is Rietveld 408576698