skiaserve: Fix /cmd/N and /cmd/N[0|1], the response was never queued.

skiaserve: Fix /cmd/N and /cmd/N[0|1], the response was never queued.

BUG=skia:
R=joshualitt@google.com, ethannicholas@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686553006

Committed: https://skia.googlesource.com/skia/+/12d47ce49e65e27f39fa20b78445e637c95b19b8

[jcgregorio, 2016-02-10 21:32:53]

Description was changed from

==========
skiaserve: Fix /cmd/N and /cmd/N[0|1], the response was never queued.

BUG=skia:
R=joshualitt@google.com, ethannicholas@google.com
==========

to

==========
skiaserve: Fix /cmd/N and /cmd/N[0|1], the response was never queued.

BUG=skia:
R=joshualitt@google.com, ethannicholas@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[ethannicholas, 2016-02-10 21:37:17]

lgtm other than nits

https://codereview.chromium.org/1686553006/diff/1/tools/skiaserve/skiaserve.cpp
File tools/skiaserve/skiaserve.cpp (right):

https://codereview.chromium.org/1686553006/diff/1/tools/skiaserve/skiaserve.c...
tools/skiaserve/skiaserve.cpp:148: const char * data = "";
nit: space before '*'

https://codereview.chromium.org/1686553006/diff/1/tools/skiaserve/skiaserve.c...
tools/skiaserve/skiaserve.cpp:150: struct MHD_Response* response =
MHD_create_response_from_buffer (strlen(data), (void*)data,
MHD_RESPMEM_PERSISTENT);
nit: space before '(', needs a line break

[jcgregorio, 2016-02-10 21:42:20]

https://codereview.chromium.org/1686553006/diff/1/tools/skiaserve/skiaserve.cpp
File tools/skiaserve/skiaserve.cpp (right):

https://codereview.chromium.org/1686553006/diff/1/tools/skiaserve/skiaserve.c...
tools/skiaserve/skiaserve.cpp:148: const char * data = "";
On 2016/02/10 at 21:37:16, ethannicholas wrote:
> nit: space before '*'

Done.

https://codereview.chromium.org/1686553006/diff/1/tools/skiaserve/skiaserve.c...
tools/skiaserve/skiaserve.cpp:150: struct MHD_Response* response =
MHD_create_response_from_buffer (strlen(data), (void*)data,
MHD_RESPMEM_PERSISTENT);
On 2016/02/10 at 21:37:16, ethannicholas wrote:
> nit: space before '(', needs a line break

Done.

[jcgregorio, 2016-02-10 21:42:21]

The CQ bit was checked by jcgregorio@google.com

[jcgregorio, 2016-02-10 21:42:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
ethannicholas@google.com
Link to the patchset: https://codereview.chromium.org/1686553006/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-02-10 21:42:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1686553006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1686553006/20001

[commit-bot: I haz the power, 2016-02-10 22:10:39]

Description was changed from

==========
skiaserve: Fix /cmd/N and /cmd/N[0|1], the response was never queued.

BUG=skia:
R=joshualitt@google.com, ethannicholas@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
skiaserve: Fix /cmd/N and /cmd/N[0|1], the response was never queued.

BUG=skia:
R=joshualitt@google.com, ethannicholas@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/12d47ce49e65e27f39fa20b78445e637c95b19b8
==========

[commit-bot: I haz the power, 2016-02-10 22:10:40]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/12d47ce49e65e27f39fa20b78445e637c95b19b8