Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: tools/skiaserve/skiaserve.cpp

Issue 1686553006: skiaserve: Fix /cmd/N and /cmd/N[0|1], the response was never queued. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/skiaserve/skiaserve.cpp
diff --git a/tools/skiaserve/skiaserve.cpp b/tools/skiaserve/skiaserve.cpp
index e2e5450fbdfd066ba7d502d94a17347c396a0180..6bc7cc78466f4bd2caab25769edb8f4eba3d57a0 100644
--- a/tools/skiaserve/skiaserve.cpp
+++ b/tools/skiaserve/skiaserve.cpp
@@ -143,6 +143,18 @@ static int process_upload_data(void* cls, enum MHD_ValueKind kind,
return MHD_YES;
}
+// SendOK just sends an empty response with a 200 OK status code.
+static int SendOK(MHD_Connection* connection) {
+ const char* data = "";
+
+ MHD_Response* response = MHD_create_response_from_buffer(strlen(data),
+ (void*)data,
+ MHD_RESPMEM_PERSISTENT);
+ int ret = MHD_queue_response(connection, 200, response);
+ MHD_destroy_response(response);
+ return ret;
+}
+
static int SendData(MHD_Connection* connection, const SkData* data, const char* type,
bool setContentDisposition = false, const char* dispositionString = nullptr) {
MHD_Response* response = MHD_create_response_from_buffer(data->size(),
@@ -228,7 +240,7 @@ public:
int n;
sscanf(commands[1].c_str(), "%d", &n);
request->fDebugCanvas->deleteDrawCommandAt(n);
- return MHD_YES;
+ return SendOK(connection);
}
// /cmd/N/[0|1]
@@ -237,7 +249,7 @@ public:
sscanf(commands[1].c_str(), "%d", &n);
sscanf(commands[2].c_str(), "%d", &toggle);
request->fDebugCanvas->toggleCommand(n, toggle);
- return MHD_YES;
+ return SendOK(connection);
}
return MHD_NO;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698