third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/NPV8Object.h » ('j') | third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp b/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

index c728205d7558e7934734666a772e0c85bc8fbec5..8d52e504492009ea90c6a2a68fb2abfc4340f6b4 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

@@ -189,7 +189,7 @@ bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, unsi

}

template <>

-bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, RefPtrWillBeMember<DOMWindow>& value)

+bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, Member<DOMWindow>& value)

{

v8::Local<v8::Value> v8Value;

if (!dictionary.get(key, v8Value))

@@ -223,7 +223,7 @@ bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, Memb

}

template <>

-bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, RefPtrWillBeMember<EventTarget>& value)

+bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, Member<EventTarget>& value)

{

v8::Local<v8::Value> v8Value;

if (!dictionary.get(key, v8Value))