third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8EventListener.h » ('j') | third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h b/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h

index 0466f0df090b52aafacd921635996af87ff7ae67..06507a3bce13e597fa4a9b25fdc0f8afece2e53a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h

@@ -41,9 +41,9 @@ class ErrorEvent;

class V8ErrorHandler final : public V8EventListener {

public:

- static PassRefPtrWillBeRawPtr<V8ErrorHandler> create(v8::Local<v8::Object> listener, bool isInline, ScriptState* scriptState)

+ static RawPtr<V8ErrorHandler> create(v8::Local<v8::Object> listener, bool isInline, ScriptState* scriptState)

{

- RefPtrWillBeRawPtr<V8ErrorHandler> eventListener = adoptRefWillBeNoop(new V8ErrorHandler(isInline, scriptState));

+ RawPtr<V8ErrorHandler> eventListener = (new V8ErrorHandler(isInline, scriptState));

sof 2016/02/09 15:45:45 adoptPtrWillBeNoop(A) => A instead?

eventListener->setListenerObject(listener);

return eventListener.release();

}