third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp » ('j') | third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp

index 6f9bdadac3d1c8033ec801742720d8ebcd2741ec..669a7dacf1ee094e0889bd7f3b717825dfa9fa61 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp

@@ -9,7 +9,7 @@

#include "bindings/core/v8/ScriptController.h"

#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8TestInterfaceEmpty.h"

-#include "bindings/core/v8/V8TestInterfaceWillBeGarbageCollected.h"

+#include "bindings/core/v8/V8TestInterfaceGarbageCollected.h"

#include "core/dom/ExecutionContext.h"

#include "wtf/Assertions.h"

#include "wtf/GetPtr.h"

@@ -197,7 +197,7 @@ void V8TestCallbackInterface::callbackWithThisValueVoidMethodStringArg(ScriptVal

ScriptController::callFunction(m_scriptState->executionContext(), m_callback.newLocal(m_scriptState->isolate()), thisHandle, 1, argv, m_scriptState->isolate());

}

-void V8TestCallbackInterface::voidMethodWillBeGarbageCollectedSequenceArg(const WillBeHeapVector<RefPtrWillBeMember<TestInterfaceWillBeGarbageCollected>>& sequenceArg)

+void V8TestCallbackInterface::voidMethodGarbageCollectedSequenceArg(const HeapVector<Member<TestInterfaceGarbageCollected>>& sequenceArg)

{

if (!canInvokeCallback())

return;

@@ -217,7 +217,7 @@ void V8TestCallbackInterface::voidMethodWillBeGarbageCollectedSequenceArg(const

ScriptController::callFunction(m_scriptState->executionContext(), m_callback.newLocal(m_scriptState->isolate()), v8::Undefined(m_scriptState->isolate()), 1, argv, m_scriptState->isolate());

}

-void V8TestCallbackInterface::voidMethodWillBeGarbageCollectedArrayArg(const WillBeHeapVector<RefPtrWillBeMember<TestInterfaceWillBeGarbageCollected>>& arrayArg)

+void V8TestCallbackInterface::voidMethodGarbageCollectedArrayArg(const HeapVector<Member<TestInterfaceGarbageCollected>>& arrayArg)

{

if (!canInvokeCallback())

return;