third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/tests/idls/core/TestCallbackInterface.idl ('K') | « third_party/WebKit/Source/bindings/tests/idls/core/TestCallbackInterface.idl ('k') | third_party/WebKit/Source/bindings/tests/idls/core/TestInterfaceWillBeGarbageCollected.idl » ('j') | third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl

diff --git a/third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl b/third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl

index 0ac0a68fd4b74a819d1fdf6c8b72b604402d2f90..62949565e3a201168cb58ceef42c643456e5efd4 100644

--- a/third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl

+++ b/third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl

@@ -14,13 +14,13 @@ dictionary TestDictionary {

TestInterface? testInterfaceOrNullMember;

TestInterfaceGarbageCollected testInterfaceGarbageCollectedMember;

TestInterfaceGarbageCollected? testInterfaceGarbageCollectedOrNullMember;

- TestInterfaceWillBeGarbageCollected testInterfaceWillBeGarbageCollectedMember;

- TestInterfaceWillBeGarbageCollected? testInterfaceWillBeGarbageCollectedOrNullMember;

+ TestInterfaceGarbageCollected testInterfaceGarbageCollectedMember;

sof 2016/02/09 15:45:45 duplication w/ above - is that legal to declare?

+ TestInterfaceGarbageCollected? testInterfaceGarbageCollectedOrNullMember;

DOMString[] stringArrayMember;

sequence<DOMString> stringSequenceMember = [];

sequence<TestInterface> testInterfaceSequenceMember = [];

sequence<TestInterfaceGarbageCollected> testInterfaceGarbageCollectedSequenceMember = [];

- sequence<TestInterfaceWillBeGarbageCollected> testInterfaceWillBeGarbageCollectedSequenceMember = [];

+ sequence<TestInterfaceGarbageCollected> testInterfaceGarbageCollectedSequenceMember = [];

TestEnum enumMember = "foo";

sequence<TestEnum> enumSequenceMember;

Element? elementOrNullMember;