third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h ('K') | « third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.h » ('j') | third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp

index a974e8bc7c6c2411a8b9bc0c80288cd605512587..23ccb8a6600db84f585c33325fa9e1aa3fe04521 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp

@@ -89,7 +89,7 @@ public:

protected:

ResourceRequest m_resourceRequest;

- RefPtrWillBePersistent<ScriptResource> m_resource;

+ Persistent<ScriptResource> m_resource;

V8TestingScope m_scope;

static int counter;

@@ -118,7 +118,7 @@ TEST_F(V8ScriptRunnerTest, parseOption)

EXPECT_FALSE(cacheHandler()->cachedMetadata(tagForCodeCache(cacheHandler())));

// The cached data is associated with the encoding.

ResourceRequest request(url());

- RefPtrWillBeRawPtr<ScriptResource> anotherResource = ScriptResource::create(request, "UTF-16");

+ RawPtr<ScriptResource> anotherResource = ScriptResource::create(request, "UTF-16");

EXPECT_FALSE(cacheHandler()->cachedMetadata(tagForParserCache(anotherResource->cacheHandler())));

}

@@ -134,7 +134,7 @@ TEST_F(V8ScriptRunnerTest, codeOption)

EXPECT_TRUE(cacheHandler()->cachedMetadata(tagForCodeCache(cacheHandler())));

// The cached data is associated with the encoding.

ResourceRequest request(url());

- RefPtrWillBeRawPtr<ScriptResource> anotherResource = ScriptResource::create(request, "UTF-16");

+ RawPtr<ScriptResource> anotherResource = ScriptResource::create(request, "UTF-16");

EXPECT_FALSE(cacheHandler()->cachedMetadata(tagForCodeCache(anotherResource->cacheHandler())));

}