third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py » ('j') | third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

diff --git a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

index 380510dda6077d4b5f6effc809e4396039bd0e02..c6697fb1fcb8f802f43ca2d910efafc234680292 100755

--- a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

+++ b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

@@ -92,7 +92,7 @@ INHERITED_EXTENDED_ATTRIBUTES = set([

'ActiveDOMObject',

'DependentLifetime',

'GarbageCollected',

- 'WillBeGarbageCollected',

+ 'GarbageCollected',

sof 2016/02/09 15:45:45 Duplicate.

])

# Main variable (filled in and exported)

@@ -186,7 +186,7 @@ def compute_global_type_info():

implemented_as_interfaces[interface_name] = interface_info['implemented_as']

inherited_extended_attributes = interface_info['inherited_extended_attributes']

- if 'WillBeGarbageCollected' in inherited_extended_attributes:

+ if 'GarbageCollected' in inherited_extended_attributes:

sof 2016/02/09 15:45:45 will_be_garbage_* no longer needed, right?

will_be_garbage_collected_interfaces.add(interface_name)

if 'GarbageCollected' in inherited_extended_attributes:

garbage_collected_interfaces.add(interface_name)