chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h - Issue 1686433002: Remove DialogDelegate::OnClosed() which is redundant with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h

Issue 1686433002: Remove DialogDelegate::OnClosed() which is redundant with (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc ('K') | « chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc ('k') | chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc » ('j') | components/app_modal/views/javascript_app_modal_dialog_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h

diff --git a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h

index c5d7eae8f539eb0f0b4b1a816895cd5dc999f419..41f11fb264528dbcacb9ee1c22b3acec9299a548 100644

--- a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h

+++ b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h

@@ -51,11 +51,13 @@ class ProfileSigninConfirmationDialogViews : public views::DialogDelegateView,

views::View* CreateExtraView() override;

bool Accept() override;

bool Cancel() override;

- void OnClosed() override;

ui::ModalType GetModalType() const override;

void ViewHierarchyChanged(

const ViewHierarchyChangedDetails& details) override;

+ // views::WidgetDelegate::

+ void WindowClosing() override;

// views::StyledLabelListener:

void StyledLabelLinkClicked(views::StyledLabel* label,

const gfx::Range& range,