Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: components/app_modal/views/javascript_app_modal_dialog_views.cc

Issue 1686433002: Remove DialogDelegate::OnClosed() which is redundant with (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/app_modal/views/javascript_app_modal_dialog_views.cc
diff --git a/components/app_modal/views/javascript_app_modal_dialog_views.cc b/components/app_modal/views/javascript_app_modal_dialog_views.cc
index b45ccbd6633ad27e042f5c01e6e956b6bae4b790..a56abe26cfb15bd1070679225880d9ab607cb6a9 100644
--- a/components/app_modal/views/javascript_app_modal_dialog_views.cc
+++ b/components/app_modal/views/javascript_app_modal_dialog_views.cc
@@ -111,18 +111,6 @@ bool JavaScriptAppModalDialogViews::Accept() {
return true;
}
-void JavaScriptAppModalDialogViews::OnClosed() {
- parent_->OnClose();
-}
-
-views::Widget* JavaScriptAppModalDialogViews::GetWidget() {
- return message_box_view_->GetWidget();
-}
-
-const views::Widget* JavaScriptAppModalDialogViews::GetWidget() const {
- return message_box_view_->GetWidget();
-}
-
base::string16 JavaScriptAppModalDialogViews::GetDialogButtonLabel(
ui::DialogButton button) const {
if (parent_->is_before_unload_dialog()) {
@@ -158,4 +146,16 @@ views::View* JavaScriptAppModalDialogViews::GetInitiallyFocusedView() {
return views::DialogDelegate::GetInitiallyFocusedView();
}
+void JavaScriptAppModalDialogViews::WindowClosing() {
+ parent_->OnClose();
+}
+
+views::Widget* JavaScriptAppModalDialogViews::GetWidget() {
+ return message_box_view_->GetWidget();
+}
+
+const views::Widget* JavaScriptAppModalDialogViews::GetWidget() const {
+ return message_box_view_->GetWidget();
+}
+
} // namespace app_modal
« no previous file with comments | « components/app_modal/views/javascript_app_modal_dialog_views.h ('k') | ui/views/window/dialog_client_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698