Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: ui/views/window/dialog_client_view.h

Issue 1686433002: Remove DialogDelegate::OnClosed() which is redundant with (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/window/dialog_client_view.h
diff --git a/ui/views/window/dialog_client_view.h b/ui/views/window/dialog_client_view.h
index 32f6a617b030d97968b6829a3b9b5cee05e95f13..8f4e0fc0d5b8cf1025764fab36b319404eb0a019 100644
--- a/ui/views/window/dialog_client_view.h
+++ b/ui/views/window/dialog_client_view.h
@@ -93,9 +93,6 @@ class VIEWS_EXPORT DialogClientView : public ClientView,
// Returns the insets for the buttons and extra view.
gfx::Insets GetButtonRowInsets() const;
- // Closes the widget.
- void Close();
-
// Sets up the focus chain for the child views. This is required since the
// delegate may choose to add/remove views at any time.
void SetupFocusChain();
@@ -111,10 +108,10 @@ class VIEWS_EXPORT DialogClientView : public ClientView,
View* footnote_view_;
// True if we've notified the delegate the window is closing and the delegate
- // allosed the close. In some situations it's possible to get two closes (see
+ // allowed the close. In some situations it's possible to get two closes (see
// http://crbug.com/71940). This is used to avoid notifying the delegate
// twice, which can have bad consequences.
- bool notified_delegate_;
+ bool delegate_allowed_close_;
DISALLOW_COPY_AND_ASSIGN(DialogClientView);
};
« no previous file with comments | « components/app_modal/views/javascript_app_modal_dialog_views.cc ('k') | ui/views/window/dialog_client_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698