Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: build/config/mac/mac_sdk.gni

Issue 1686373002: Allow WebRTC to require Mac 10.7 deployments in GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update README Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build_overrides/README.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/mac_sdk.gni
diff --git a/build/config/mac/mac_sdk.gni b/build/config/mac/mac_sdk.gni
index 8767aa4108b85a10780e1795aad7e88df0a1104d..23e2d83af94c59ca42bcc698f0e037c2a0dcd078 100644
--- a/build/config/mac/mac_sdk.gni
+++ b/build/config/mac/mac_sdk.gni
@@ -4,12 +4,17 @@
import("//build/config/chrome_build.gni")
+# See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453.
+# We can drop the rtc_require_mac_10_7_deployment flag when Chromium
Nico 2016/04/04 18:01:22 rtc_require_mac_10_7_deployment isn't referenced b
tkchin_webrtc 2016/04/04 18:49:01 We haven't done the work on WebRTC side to fix GN
+# also requires a 10.7 deployment target.
+import("//build_overrides/build.gni")
+
declare_args() {
# Minimum supported version of the Mac SDK.
mac_sdk_min = "10.10"
# Minimum supported version of OSX.
- mac_deployment_target = "10.6"
+ mac_deployment_target = mac_deployment_target_build_override
# Path to a specific version of the Mac SDK, not including a backslash at
# the end. If empty, the path to the lowest version greater than or equal to
« no previous file with comments | « no previous file | build_overrides/README.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698