Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: build/config/mac/mac_sdk.gni

Issue 1686373002: Allow WebRTC to require Mac 10.7 deployments in GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update README Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build_overrides/README.md » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 6
7 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453.
8 # We can drop the rtc_require_mac_10_7_deployment flag when Chromium
Nico 2016/04/04 18:01:22 rtc_require_mac_10_7_deployment isn't referenced b
tkchin_webrtc 2016/04/04 18:49:01 We haven't done the work on WebRTC side to fix GN
9 # also requires a 10.7 deployment target.
10 import("//build_overrides/build.gni")
11
7 declare_args() { 12 declare_args() {
8 # Minimum supported version of the Mac SDK. 13 # Minimum supported version of the Mac SDK.
9 mac_sdk_min = "10.10" 14 mac_sdk_min = "10.10"
10 15
11 # Minimum supported version of OSX. 16 # Minimum supported version of OSX.
12 mac_deployment_target = "10.6" 17 mac_deployment_target = mac_deployment_target_build_override
13 18
14 # Path to a specific version of the Mac SDK, not including a backslash at 19 # Path to a specific version of the Mac SDK, not including a backslash at
15 # the end. If empty, the path to the lowest version greater than or equal to 20 # the end. If empty, the path to the lowest version greater than or equal to
16 # mac_sdk_min is used. 21 # mac_sdk_min is used.
17 mac_sdk_path = "" 22 mac_sdk_path = ""
18 } 23 }
19 24
20 find_sdk_args = [ "--print_sdk_path" ] 25 find_sdk_args = [ "--print_sdk_path" ]
21 if (is_chrome_branded && is_official_build) { 26 if (is_chrome_branded && is_official_build) {
22 find_sdk_args += [ 27 find_sdk_args += [
23 "--verify", 28 "--verify",
24 mac_sdk_min, 29 mac_sdk_min,
25 "--sdk_path=" + mac_sdk_path, 30 "--sdk_path=" + mac_sdk_path,
26 ] 31 ]
27 } else { 32 } else {
28 find_sdk_args += [ mac_sdk_min ] 33 find_sdk_args += [ mac_sdk_min ]
29 } 34 }
30 35
31 # The tool will print the SDK path on the first line, and the version on the 36 # The tool will print the SDK path on the first line, and the version on the
32 # second line. 37 # second line.
33 find_sdk_lines = 38 find_sdk_lines =
34 exec_script("//build/mac/find_sdk.py", find_sdk_args, "list lines") 39 exec_script("//build/mac/find_sdk.py", find_sdk_args, "list lines")
35 mac_sdk_version = find_sdk_lines[1] 40 mac_sdk_version = find_sdk_lines[1]
36 if (mac_sdk_path == "") { 41 if (mac_sdk_path == "") {
37 mac_sdk_path = find_sdk_lines[0] 42 mac_sdk_path = find_sdk_lines[0]
38 } 43 }
OLDNEW
« no previous file with comments | « no previous file | build_overrides/README.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698