chrome/browser/extensions/extension_function_histogram_value.h - Issue 168623003: Add chrome.screenlockPrivate API functions to handle alternate auth types.

Unified Diff: chrome/browser/extensions/extension_function_histogram_value.h

Issue 168623003: Add chrome.screenlockPrivate API functions to handle alternate auth types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update screen locker to send event Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/screen_locker.cc ('k') | chrome/common/extensions/api/screenlock_private.idl » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_function_histogram_value.h

diff --git a/chrome/browser/extensions/extension_function_histogram_value.h b/chrome/browser/extensions/extension_function_histogram_value.h

index 72614ac4d4e7339ba998cae7d4632f61c0877fe5..e1c07587dba7243cda9a5a8df90cb283fc8f74d0 100644

--- a/chrome/browser/extensions/extension_function_histogram_value.h

+++ b/chrome/browser/extensions/extension_function_histogram_value.h

@@ -748,6 +748,10 @@ enum HistogramValue {

ACTIVITYLOGPRIVATE_DELETEACTIVITIES,

NETWORKINGPRIVATE_SETWIFITDLSENABLEDSTATE,

NETWORKINGPRIVATE_GETWIFITDLSSTATUS,

+ SCREENLOCKPRIVATE_HIDEBUTTON,

+ SCREENLOCKPRIVATE_SETAUTHTYPE,

+ SCREENLOCKPRIVATE_GETAUTHTYPE,

+ SCREENLOCKPRIVATE_ACCEPTAUTHATTEMPT,

ENUM_BOUNDARY // Last entry: Add new entries above.

Alexei Svitkine (slow) 2014/02/24 15:54:33 Nit: I'd change this comment to: // Last entry: A

Tim Song 2014/02/24 19:10:58 This should probably be done in a separate CL as t

Alexei Svitkine (slow) 2014/02/24 19:25:18 Really? Changing the comment would break the presu

};