chrome/browser/extensions/extension_function_histogram_value.h - Issue 168623003: Add chrome.screenlockPrivate API functions to handle alternate auth types.

Side by Side Diff: chrome/browser/extensions/extension_function_histogram_value.h

Issue 168623003: Add chrome.screenlockPrivate API functions to handle alternate auth types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update screen locker to send event Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_HISTOGRAM_VALUE_H_	5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_HISTOGRAM_VALUE_H_

6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_HISTOGRAM_VALUE_H_	6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_HISTOGRAM_VALUE_H_

7	7

8	8

9 namespace extensions {	9 namespace extensions {

10 namespace functions {	10 namespace functions {

(...skipping 730 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
741 HOTWORDPRIVATE_GETSTATUS,	741 HOTWORDPRIVATE_GETSTATUS,

742 APP_CURRENTWINDOWINTERNAL_SETBADGEICON,	742 APP_CURRENTWINDOWINTERNAL_SETBADGEICON,

743 APP_CURRENTWINDOWINTERNAL_CLEARBADGE,	743 APP_CURRENTWINDOWINTERNAL_CLEARBADGE,

744 WEBVIEW_SETZOOM,	744 WEBVIEW_SETZOOM,

745 WEBVIEW_GETZOOM,	745 WEBVIEW_GETZOOM,

746 DEVELOPERPRIVATE_REQUESTFILESOURCE,	746 DEVELOPERPRIVATE_REQUESTFILESOURCE,

747 DEVELOPERPRIVATE_OPENDEVTOOLS,	747 DEVELOPERPRIVATE_OPENDEVTOOLS,

748 ACTIVITYLOGPRIVATE_DELETEACTIVITIES,	748 ACTIVITYLOGPRIVATE_DELETEACTIVITIES,

749 NETWORKINGPRIVATE_SETWIFITDLSENABLEDSTATE,	749 NETWORKINGPRIVATE_SETWIFITDLSENABLEDSTATE,

750 NETWORKINGPRIVATE_GETWIFITDLSSTATUS,	750 NETWORKINGPRIVATE_GETWIFITDLSSTATUS,

	751 SCREENLOCKPRIVATE_HIDEBUTTON,

	752 SCREENLOCKPRIVATE_SETAUTHTYPE,

	753 SCREENLOCKPRIVATE_GETAUTHTYPE,

	754 SCREENLOCKPRIVATE_ACCEPTAUTHATTEMPT,

751 ENUM_BOUNDARY // Last entry: Add new entries above.	755 ENUM_BOUNDARY // Last entry: Add new entries above.
	Alexei Svitkine (slow) 2014/02/24 15:54:33 Nit: I'd change this comment to: // Last entry: A Nit: I'd change this comment to: // Last entry: Add new entries above and ensure to update histograms.xml. (And maybe put it above the enum, since it probably won't fit at the end of the line anymore.) Tim Song 2014/02/24 19:10:58 This should probably be done in a separate CL as t Show quoted text On 2014/02/24 15:54:33, Alexei Svitkine wrote: > Nit: I'd change this comment to: > > // Last entry: Add new entries above and ensure to update histograms.xml. > > (And maybe put it above the enum, since it probably won't fit at the end of the > line anymore.) This should probably be done in a separate CL as the PRESUBMIT and PRESUBMIT tests need to be updated to handle a different ENUM_END_MARKER. Alexei Svitkine (slow) 2014/02/24 19:25:18 Really? Changing the comment would break the presu Show quoted text On 2014/02/24 19:10:58, Tim Song wrote: > On 2014/02/24 15:54:33, Alexei Svitkine wrote: > > Nit: I'd change this comment to: > > > > // Last entry: Add new entries above and ensure to update histograms.xml. > > > > (And maybe put it above the enum, since it probably won't fit at the end of > the > > line anymore.) > > This should probably be done in a separate CL as the PRESUBMIT and PRESUBMIT > tests need to be updated to handle a different ENUM_END_MARKER. Really? Changing the comment would break the presubmits? (I guess if they don't expect a comment on the start of the line...) I'm okay punting this to a separate CL if its indeed this much hassle. (Though please do follow-up with this, as I think having the comment here (at the bottom) will indeed prevent this sort of omission in the future.)
752 };	756 };

753	757

754 } // namespace functions	758 } // namespace functions

755 } // namespace extensions	759 } // namespace extensions

756	760

757 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_HISTOGRAM_VALUE_H_	761 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_HISTOGRAM_VALUE_H_

OLD	NEW