Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1686143004: integrated SkDebugCanvas JSON support with UrlDataManager (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : gyp updates #

Patch Set 3 : rebased #

Patch Set 4 : added cast to deal with differing-size ints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+368 lines, -340 lines) Patch
M gyp/SampleApp.gyp View 1 1 chunk +2 lines, -1 line 0 comments Download
M gyp/bench.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M gyp/dm.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M gyp/visualbench.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/debugger/SkDrawCommand.h View 30 chunks +55 lines, -55 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 1 2 3 72 chunks +307 lines, -283 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686143004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686143004/20001
4 years, 10 months ago (2016-02-11 16:44:34 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7-Debug-iOS-Trybot/builds/187)
4 years, 10 months ago (2016-02-11 16:45:26 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686143004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686143004/40001
4 years, 10 months ago (2016-02-11 17:59:21 UTC) #7
ethannicholas
4 years, 10 months ago (2016-02-11 17:59:57 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/6151)
4 years, 10 months ago (2016-02-11 18:01:49 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686143004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686143004/60001
4 years, 10 months ago (2016-02-11 18:05:35 UTC) #13
joshualitt
On 2016/02/11 18:01:49, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 10 months ago (2016-02-11 18:08:45 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 18:34:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686143004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686143004/60001
4 years, 10 months ago (2016-02-11 18:34:30 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 18:35:25 UTC) #20
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f62a8b786c0e17a3818d0bdc8dbf1c627b063e1b

Powered by Google App Engine
This is Rietveld 408576698