tools/debugger/SkDebugCanvas.cpp - Issue 1686143004: integrated SkDebugCanvas JSON support with UrlDataManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/debugger/SkDebugCanvas.cpp

Issue 1686143004: integrated SkDebugCanvas JSON support with UrlDataManager (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: added cast to deal with differing-size ints Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/debugger/SkDebugCanvas.cpp

diff --git a/tools/debugger/SkDebugCanvas.cpp b/tools/debugger/SkDebugCanvas.cpp

index 8b71c0fb2c44c55d9b7168b97585256372aa2dc9..0c79b755f36525375d01a869dc3ba829df15ff15 100644

--- a/tools/debugger/SkDebugCanvas.cpp

+++ b/tools/debugger/SkDebugCanvas.cpp

@@ -323,7 +323,7 @@ Json::Value SkDebugCanvas::toJSON(UrlDataManager& urlDataManager, int n) {

result[SKDEBUGCANVAS_ATTRIBUTE_VERSION] = Json::Value(SKDEBUGCANVAS_VERSION);

Json::Value commands = Json::Value(Json::arrayValue);

for (int i = 0; i < this->getSize() && i < n; i++) {

- commands[i] = this->getDrawCommandAt(i)->toJSON();

+ commands[i] = this->getDrawCommandAt(i)->toJSON(urlDataManager);

}

result[SKDEBUGCANVAS_ATTRIBUTE_COMMANDS] = commands;

return result;

« no previous file with comments | « gyp/visualbench.gyp ('k') | tools/debugger/SkDrawCommand.h » ('j') | no next file with comments »