Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: media/video/gpu_memory_buffer_video_frame_pool.h

Issue 1686123004: Post GpuMemoryBufferVideoFramePool deletion on media thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Using WeakPtr Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/gpu_memory_buffer_video_frame_pool.h
diff --git a/media/video/gpu_memory_buffer_video_frame_pool.h b/media/video/gpu_memory_buffer_video_frame_pool.h
index ed4b3617e53cd39b0cf78d7f7dd7e6b9d16ddd47..aef6230687409ec6841edc7278950a9052813d5d 100644
--- a/media/video/gpu_memory_buffer_video_frame_pool.h
+++ b/media/video/gpu_memory_buffer_video_frame_pool.h
@@ -7,6 +7,7 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
#include "base/task_runner.h"
#include "media/base/video_frame.h"
@@ -48,9 +49,12 @@ class MEDIA_EXPORT GpuMemoryBufferVideoFramePool {
const scoped_refptr<VideoFrame>& video_frame,
const FrameReadyCB& frame_ready_cb);
+ base::WeakPtr<GpuMemoryBufferVideoFramePool> GetWeakPtr();
mcasas 2016/02/11 15:40:41 nit: for cases like this you can also make the cla
+
private:
class PoolImpl;
scoped_refptr<PoolImpl> pool_impl_;
+ base::WeakPtrFactory<GpuMemoryBufferVideoFramePool> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(GpuMemoryBufferVideoFramePool);
};

Powered by Google App Engine
This is Rietveld 408576698