Post GpuMemoryBufferVideoFramePool deletion on media thread

content/renderer/media/media_stream_video_renderer_sink.cc

Index: content/renderer/media/media_stream_video_renderer_sink.cc
diff --git a/content/renderer/media/media_stream_video_renderer_sink.cc b/content/renderer/media/media_stream_video_renderer_sink.cc
index 709f9d51d8f11139c35d11b2eb15235c36a52848..1fe69b26584d74dc9daf4df820dba92a1dc7ab7f 100644
--- a/content/renderer/media/media_stream_video_renderer_sink.cc
+++ b/content/renderer/media/media_stream_video_renderer_sink.cc
@@ -40,6 +40,10 @@ MediaStreamVideoRendererSink::MediaStreamVideoRendererSink(
 }
 
 MediaStreamVideoRendererSink::~MediaStreamVideoRendererSink() {
+  if (gpu_memory_buffer_pool_) {
+    media_task_runner_->DeleteSoon(FROM_HERE,

[DaleCurtis, 2016/02/11 01:28:02]

You don't need the GetWeakPtr() method, just DeleteSoon() on media task runner
since if this class is destructed it can't post any new tasks and all
outstanding ones will have completed. You already invalidate your own internal
weakptr so no calls should come back.

[emircan, 2016/02/11 01:34:48]

I agree that this would work as well. I am reverting back to PS#2.

+                                   gpu_memory_buffer_pool_.release());
+  }
 }
 
 void MediaStreamVideoRendererSink::Start() {
@@ -113,7 +117,7 @@ void MediaStreamVideoRendererSink::OnVideoFrame(
       FROM_HERE,
       base::Bind(
           &media::GpuMemoryBufferVideoFramePool::MaybeCreateHardwareFrame,
-          base::Unretained(gpu_memory_buffer_pool_.get()), frame,
+          gpu_memory_buffer_pool_->GetWeakPtr(), frame,
           media::BindToCurrentLoop(
               base::Bind(&MediaStreamVideoRendererSink::FrameReady,
                          weak_factory_.GetWeakPtr()))));