Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 1686063004: Sending generated vote on password generation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix BUILD.gn Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/chrome_password_manager_client.h
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h
index d64a2d7820a9103f94edd9ec408fe6275242450c..97b2d4050161ca4c1f4b53da8222a603448e54f7 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.h
+++ b/chrome/browser/password_manager/chrome_password_manager_client.h
@@ -127,10 +127,15 @@ class ChromePasswordManagerClient
// Causes the password generation UI to be shown for the specified form.
// The popup will be anchored at |element_bounds|. The generated password
- // will be no longer than |max_length|.
+ // will be no longer than |max_length|. |generation_element| should contain a
+ // name of a password field at which generation popup is attached.
+ // |is_manually_triggered| informs whether it is automatically or manually
+ // triggered generation.
void ShowPasswordGenerationPopup(content::RenderFrameHost* render_frame_host,
const gfx::RectF& bounds,
int max_length,
+ const base::string16& generation_element,
+ bool is_manually_triggered,
const autofill::PasswordForm& form);
// Causes the password editing UI to be shown anchored at |element_bounds|.
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698