Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5764)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1686063004: Sending generated vote on password generation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix BUILD.gn Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index f72ac4f910f155ce5683980015771d27dd66cf34..3046ea7d74e5b917c04b8cbfda6436e01d98b69a 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -503,17 +503,21 @@ void ChromePasswordManagerClient::ShowPasswordGenerationPopup(
content::RenderFrameHost* render_frame_host,
const gfx::RectF& bounds,
int max_length,
+ const base::string16& generation_element,
+ bool is_manually_triggered,
const autofill::PasswordForm& form) {
// TODO(gcasto): Validate data in PasswordForm.
+ auto* driver = driver_factory_->GetDriverForFrame(render_frame_host);
+ password_manager_.SetGenerationElementAndReasonForForm(
+ driver, form, generation_element, is_manually_triggered);
gfx::RectF element_bounds_in_screen_space = GetBoundsInScreenSpace(bounds);
popup_controller_ =
autofill::PasswordGenerationPopupControllerImpl::GetOrCreate(
popup_controller_, element_bounds_in_screen_space, form, max_length,
- &password_manager_,
- driver_factory_->GetDriverForFrame(render_frame_host), observer_,
- web_contents(), web_contents()->GetNativeView());
+ &password_manager_, driver, observer_, web_contents(),
+ web_contents()->GetNativeView());
popup_controller_->Show(true /* display_password */);
}

Powered by Google App Engine
This is Rietveld 408576698