Sending generated vote on password generation.

components/autofill/core/browser/proto/server.proto

Index: components/autofill/core/browser/proto/server.proto
diff --git a/components/autofill/core/browser/proto/server.proto b/components/autofill/core/browser/proto/server.proto
index 08ac272fd94c02da169c351f20a89a3da28c7b27..3ee29d434c8d5842bec78ffcc6a86d3588749737 100644
--- a/components/autofill/core/browser/proto/server.proto
+++ b/components/autofill/core/browser/proto/server.proto
@@ -34,7 +34,7 @@ message AutofillQueryResponseContents {
 
 // This message contains information about the field types in a single form.
 // It is sent by the toolbar to contribute to the field type statistics.
-// Next available id: 17
+// Next available id: 18
 message AutofillUploadContents {
   required string client_version = 1;
   required fixed64 form_signature = 2;
@@ -72,6 +72,9 @@ message AutofillUploadContents {
     // The label that is used alongside the field. Its value is truncated at
     // 200 characters.
     optional string label = 11;
+
+    // The type of password generation, if it happened.
+    optional fixed32 generation_event = 17;

[vabr (Chromium), 2016/02/17 13:43:22]

I'd like mathp@ to check if this looks like a good place to add the information.

[Mathieu, 2016/02/17 15:57:26]

I would prefer the enum PasswordGenerationEvent to be defined in this file.

here's how to define an enum in proto:
https://code.google.com/p/chromium/codesearch#chromium/src/sync/protocol/sync...

(the reason we don't have other enums in this file is that the protos are old.
New definitions should be more modern).

[dvadym, 2016/02/19 16:25:05]

Thanks, I've introduced an enum.

   }
   // Signature of the form action host (e.g. Hash64Bit("example.com")).
   optional fixed64 action_signature = 13;
@@ -86,4 +89,4 @@ message AutofillUploadContents {
 
   // The form name.
   optional string form_name = 16;
-}
+}

[vabr (Chromium), 2016/02/17 13:43:22]

nit: Do you know what is the change on this line? Is it adding/losing a newline?
Should we keep the current state?

[dvadym, 2016/02/19 16:25:05]

I didn't do any changes and I don't see any reason why it shows that lines are
different. I even made git checkout master <this file>. So it seems like some
bug in a comparison tool.