Sending generated vote on password generation.

components/autofill/core/browser/proto/server.proto

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
 package autofill;
 
@@ skipping 16 matching lines @@
 // This message is the result of an Autofill query. It holds the field type
 // information.
 // Next available id: 7
 message AutofillQueryResponseContents {
   optional bool upload_required = 1;
   repeated group Field = 2 { required fixed32 autofill_type = 3; }
 }
 
 // This message contains information about the field types in a single form.
 // It is sent by the toolbar to contribute to the field type statistics.
-// Next available id: 17
+// Next available id: 18
 message AutofillUploadContents {
   required string client_version = 1;
   required fixed64 form_signature = 2;
 
   // True if the autofill feature was used to fill this form, false otherwise.
   required bool autofill_used = 3;
 
   // A string representing a bit array of what personal information items
   // the user has entered in the autofill settings dialog.
   // The corresponding bit is set if the user has that particular
@@ skipping 17 matching lines @@
 
     // The value of the autocomplete attribute on the field, if present.
     optional string autocomplete = 9;
 
     // The type of input control for this field (e.g. text, textarea, email).
     optional string type = 10;
 
     // The label that is used alongside the field. Its value is truncated at
     // 200 characters.
     optional string label = 11;
+
+    // The type of password generation, if it happened.
+    optional fixed32 generation_event = 17;

[vabr (Chromium), 2016/02/17 13:43:22]

I'd like mathp@ to check if this looks like a good place to add the information.

[Mathieu, 2016/02/17 15:57:26]

I would prefer the enum PasswordGenerationEvent to be defined in this file.

here's how to define an enum in proto:
https://code.google.com/p/chromium/codesearch#chromium/src/sync/protocol/sync...

(the reason we don't have other enums in this file is that the protos are old.
New definitions should be more modern).

[dvadym, 2016/02/19 16:25:05]

Thanks, I've introduced an enum.

   }
   // Signature of the form action host (e.g. Hash64Bit("example.com")).
   optional fixed64 action_signature = 13;
 
   // Signature of the form which is used for password generation debugging.
   // Currently is used when password generated on a password field of a
   // registration form is used on a password field of a login form.
   optional fixed64 login_form_signature = 14;
 
   // Whether a form submission event was observed.
   optional bool submission = 15;
 
   // The form name.
   optional string form_name = 16;
-}
+}

[vabr (Chromium), 2016/02/17 13:43:22]

nit: Do you know what is the change on this line? Is it adding/losing a newline?
Should we keep the current state?

[dvadym, 2016/02/19 16:25:05]

I didn't do any changes and I don't see any reason why it shows that lines are
different. I even made git checkout master <this file>. So it seems like some
bug in a comparison tool.