Sending generated vote on password generation.

components/autofill/content/renderer/password_generation_agent.cc

Index: components/autofill/content/renderer/password_generation_agent.cc
diff --git a/components/autofill/content/renderer/password_generation_agent.cc b/components/autofill/content/renderer/password_generation_agent.cc
index ded1af01e2087b4e339bdfe93ffda97c481149dc..02df384c7f8534cc86bb0f28e348f760d7fcdc0b 100644
--- a/components/autofill/content/renderer/password_generation_agent.cc
+++ b/components/autofill/content/renderer/password_generation_agent.cc
@@ -120,6 +120,7 @@ PasswordGenerationAgent::PasswordGenerationAgent(
     PasswordAutofillAgent* password_agent)
     : content::RenderFrameObserver(render_frame),
       password_is_generated_(false),
+      is_manually_triggered(false),
       password_edited_(false),
       generation_popup_shown_(false),
       editing_popup_shown_(false),
@@ -438,11 +439,13 @@ bool PasswordGenerationAgent::TextDidChangeInTextField(
 
 void PasswordGenerationAgent::ShowGenerationPopup() {
   Send(new AutofillHostMsg_ShowPasswordGenerationPopup(
-           routing_id(),
-           render_frame()->GetRenderView()->ElementBoundsInWindow(
-               generation_element_),
-           generation_element_.maxLength(),
-           *generation_form_data_->form));
+      routing_id(),
+      render_frame()->GetRenderView()->ElementBoundsInWindow(
+          generation_element_),
+      generation_element_.maxLength(),
+      generation_element_.nameForAutofill(),
+      is_manually_triggered,
+      *generation_form_data_->form));
   generation_popup_shown_ = true;
 }
 
@@ -485,6 +488,7 @@ void PasswordGenerationAgent::OnGeneratePassword() {
       password_elements, element->nameForAutofill());
   generation_form_data_.reset(new AccountCreationFormData(
       make_linked_ptr(password_form.release()), password_elements));
+  is_manually_triggered = true;

[vabr (Chromium), 2016/02/17 13:43:22]

nit: Currently this method is only called when the user triggers generation, so
setting the flag here is OK. But the contract for this method (in the comment
above its declaration) does not require that it is always called after the user
manually triggered generation. So in the future, someone could reuse it for the
automatic generation, resulting in bad votes. Could you please add the manual
triggering to the method's contract (preferably also to the browser-code side of
generation triggering)?

[dvadym, 2016/02/19 16:25:05]

Thanks, it makes perfect sense, I've renamed to UserTriggeredGeneratePassword

   ShowGenerationPopup();
 }