Sending generated vote on password generation.

components/autofill/content/renderer/password_generation_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_generation_agent.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "components/autofill/content/common/autofill_messages.h"
@@ skipping 102 matching lines @@
     : form(password_form),
       password_elements(passwords) {}
 
 PasswordGenerationAgent::AccountCreationFormData::~AccountCreationFormData() {}
 
 PasswordGenerationAgent::PasswordGenerationAgent(
     content::RenderFrame* render_frame,
     PasswordAutofillAgent* password_agent)
     : content::RenderFrameObserver(render_frame),
       password_is_generated_(false),
+      is_manually_triggered(false),
       password_edited_(false),
       generation_popup_shown_(false),
       editing_popup_shown_(false),
       enabled_(password_generation::IsPasswordGenerationEnabled()),
       password_agent_(password_agent) {
   VLOG(2) << "Password Generation is " << (enabled_ ? "Enabled" : "Disabled");
 }
 PasswordGenerationAgent::~PasswordGenerationAgent() {}
 
 void PasswordGenerationAgent::DidFinishDocumentLoad() {
@@ skipping 298 matching lines @@
     // characters typed, so keep offering the password. Note this function
     // will just keep the previous popup if one is already showing.
     ShowGenerationPopup();
   }
 
   return true;
 }
 
 void PasswordGenerationAgent::ShowGenerationPopup() {
   Send(new AutofillHostMsg_ShowPasswordGenerationPopup(
-           routing_id(),
-           render_frame()->GetRenderView()->ElementBoundsInWindow(
-               generation_element_),
-           generation_element_.maxLength(),
-           *generation_form_data_->form));
+      routing_id(),
+      render_frame()->GetRenderView()->ElementBoundsInWindow(
+          generation_element_),
+      generation_element_.maxLength(),
+      generation_element_.nameForAutofill(),
+      is_manually_triggered,
+      *generation_form_data_->form));
   generation_popup_shown_ = true;
 }
 
 void PasswordGenerationAgent::ShowEditingPopup() {
   Send(new AutofillHostMsg_ShowPasswordEditingPopup(
            routing_id(),
            render_frame()->GetRenderView()->ElementBoundsInWindow(
                generation_element_),
            *generation_form_data_->form));
   editing_popup_shown_ = true;
@@ skipping 22 matching lines @@
   if (!password_form)
     return;
 
   generation_element_ = *element;
   std::vector<blink::WebInputElement> password_elements;
   GetAccountCreationPasswordFields(form, &password_elements);
   password_elements = FindPasswordElementsForGeneration(
       password_elements, element->nameForAutofill());
   generation_form_data_.reset(new AccountCreationFormData(
       make_linked_ptr(password_form.release()), password_elements));
+  is_manually_triggered = true;

[vabr (Chromium), 2016/02/17 13:43:22]

nit: Currently this method is only called when the user triggers generation, so
setting the flag here is OK. But the contract for this method (in the comment
above its declaration) does not require that it is always called after the user
manually triggered generation. So in the future, someone could reuse it for the
automatic generation, resulting in bad votes. Could you please add the manual
triggering to the method's contract (preferably also to the browser-code side of
generation triggering)?

[dvadym, 2016/02/19 16:25:05]

Thanks, it makes perfect sense, I've renamed to UserTriggeredGeneratePassword

   ShowGenerationPopup();
 }
 
 }  // namespace autofill