Remove unnecessary variable HTMLMediaElement::m_haveVisibleTextTrack

third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 7a3c5bb811ac9c53744959f8ea10062c0685cee2..d2709fe4b7f5065bdc334cd9ec6bc30306ae0199 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -324,7 +324,6 @@ HTMLMediaElement::HTMLMediaElement(const QualifiedName& tagName, Document& docum
     , m_completelyLoaded(false)
     , m_havePreparedToPlay(false)
     , m_tracksAreReady(true)
-    , m_haveVisibleTextTrack(false)
     , m_processingPreferenceChange(false)
     , m_remoteRoutesAvailable(false)
     , m_playingRemotely(false)
@@ -3363,10 +3362,10 @@ void HTMLMediaElement::configureTextTrackDisplay()
     if (m_processingPreferenceChange)
         return;
 
-    m_haveVisibleTextTrack = m_textTracks->hasShowingTracks();
-    m_closedCaptionsVisible = m_haveVisibleTextTrack;
+    bool haveVisibleTextTrack = m_textTracks->hasShowingTracks();
+    m_closedCaptionsVisible = haveVisibleTextTrack;
 
-    if (!m_haveVisibleTextTrack && !mediaControls())
+    if (!haveVisibleTextTrack && !mediaControls())

[Srirama, 2016/02/10 12:50:50]

Local variable can be removed and use m_closedCaptionsVisible directly but i
kept it for better readability. WDYT? should i remove it as well?

[fs, 2016/02/10 14:29:34]

I don't mind either way. I think I agree that using the local is slightly more
readable though.

[philipj_slow, 2016/02/11 14:41:38]

WFM too

         return;
 
     if (mediaControls())