Remove unnecessary variable HTMLMediaElement::m_haveVisibleTextTrack

third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 306 matching lines @@
     , m_autoplaying(true)
     , m_muted(false)
     , m_paused(true)
     , m_seeking(false)
     , m_sentStalledEvent(false)
     , m_sentEndEvent(false)
     , m_closedCaptionsVisible(false)
     , m_completelyLoaded(false)
     , m_havePreparedToPlay(false)
     , m_tracksAreReady(true)
-    , m_haveVisibleTextTrack(false)
     , m_processingPreferenceChange(false)
     , m_remoteRoutesAvailable(false)
     , m_playingRemotely(false)
     , m_isFinalizing(false)
     , m_initialPlayWithoutUserGesture(false)
     , m_autoplayMediaCounted(false)
     , m_inOverlayFullscreenVideo(false)
     , m_audioTracks(AudioTrackList::create(*this))
     , m_videoTracks(VideoTrackList::create(*this))
     , m_textTracks(nullptr)
@@ skipping 3018 matching lines @@
 }
 
 void HTMLMediaElement::configureTextTrackDisplay()
 {
     ASSERT(m_textTracks);
     WTF_LOG(Media, "HTMLMediaElement::configureTextTrackDisplay(%p)", this);
 
     if (m_processingPreferenceChange)
         return;
 
-    m_haveVisibleTextTrack = m_textTracks->hasShowingTracks();
-    m_closedCaptionsVisible = m_haveVisibleTextTrack;
+    bool haveVisibleTextTrack = m_textTracks->hasShowingTracks();
+    m_closedCaptionsVisible = haveVisibleTextTrack;
 
-    if (!m_haveVisibleTextTrack && !mediaControls())
+    if (!haveVisibleTextTrack && !mediaControls())

[Srirama, 2016/02/10 12:50:50]

Local variable can be removed and use m_closedCaptionsVisible directly but i
kept it for better readability. WDYT? should i remove it as well?

[fs, 2016/02/10 14:29:34]

I don't mind either way. I think I agree that using the local is slightly more
readable though.

[philipj_slow, 2016/02/11 14:41:38]

WFM too

         return;
 
     if (mediaControls())
         mediaControls()->changedClosedCaptionsVisibility();
 
     cueTimeline().updateActiveCues(currentTime());
 
     // Note: The "time marches on" algorithm (updateActiveCues) runs the "rules
     // for updating the text track rendering" (updateTextTrackDisplay) only for
     // "affected tracks", i.e. tracks where the the active cues have changed.
@@ skipping 244 matching lines @@
 {
     visitor->trace(m_client);
 }
 
 DEFINE_TRACE(HTMLMediaElement::AudioSourceProviderImpl)
 {
     visitor->trace(m_client);
 }
 
 } // namespace blink